Messages in this thread | | | Date | Tue, 07 Aug 2012 20:23:26 -0600 | From | David Ahern <> | Subject | Re: [PATCH 1/2] perf tools: Initial bash completion support |
| |
On 8/7/12 7:10 PM, Namhyung Kim wrote: > On Tue, 07 Aug 2012 16:10:54 -0600, David Ahern wrote: >> On 8/7/12 11:00 AM, Frederic Weisbecker wrote: >>> diff --git a/tools/perf/Makefile b/tools/perf/Makefile >>> index 35655c3..ddfb7e5 100644 >>> --- a/tools/perf/Makefile >>> +++ b/tools/perf/Makefile >>> @@ -951,6 +951,7 @@ install: all >>> $(INSTALL) scripts/python/Perf-Trace-Util/lib/Perf/Trace/* -t '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/scripts/python/Perf-Trace-Util/lib/Perf/Trace' >>> $(INSTALL) scripts/python/*.py -t '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/scripts/python' >>> $(INSTALL) scripts/python/bin/* -t '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/scripts/python/bin' >>> + $(INSTALL) -m 755 bash_completion $(DESTDIR_SQ)/etc/bash_completion.d/perf >> >> still getting an error here: >> >> $ make DESTDIR=/tmp/junk-perf O=/tmp/pbuild -C tools/perf/ install >> ... >> install -m 755 bash_completion /tmp/junk-perf/etc/bash_completion.d/perf >> install: cannot create regular file >> /tmp/junk-perf/etc/bash_completion.d/perf': No such file or directory >> make: *** [install] Error 1 >> make: Leaving directory `/opt/sw/ahern/perf.git/tools/perf' > > Does patch below fix it?
Of course. I was too lazy to do that; one liner for Frederic to add - though the sysconfdir integration is nice.
David
| |