Messages in this thread Patch in this message | | | From | Minchan Kim <> | Subject | [PATCH] compaction: fix deferring compaction mistake | Date | Wed, 8 Aug 2012 09:57:44 +0900 |
| |
[1] fixed bad deferring policy but made mistake about checking compact_order_failed in __compact_pgdat so it can't update compact_order_failed with new order. It ends up preventing working of deffering policy rightly. This patch fixes it.
[1] aff62249, vmscan: only defer compaction for failed order and higher
Cc: Rik van Riel <riel@redhat.com> Cc: Mel Gorman <mel@csn.ul.ie> Signed-off-by: Minchan Kim <minchan@kernel.org> --- mm/compaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/compaction.c b/mm/compaction.c index e78cb96..b6984e2 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -861,7 +861,7 @@ static int __compact_pgdat(pg_data_t *pgdat, struct compact_control *cc) if (cc->order > 0) { int ok = zone_watermark_ok(zone, cc->order, low_wmark_pages(zone), 0, 0); - if (ok && cc->order > zone->compact_order_failed) + if (ok && cc->order >= zone->compact_order_failed) zone->compact_order_failed = cc->order + 1; /* Currently async compaction is never deferred. */ else if (!ok && cc->sync) -- 1.7.9.5
| |