lkml.org 
[lkml]   [2012]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 059/122] cgroup: cgroup_rm_files() was calling simple_unlink() with the wrong inode
    Date
    From: Greg KH <gregkh@linuxfoundation.org>

    3.5-stable review patch. If anyone has any objections, please let me know.

    ------------------

    From: Tejun Heo <tj@kernel.org>

    commit ce27e317ba22b359bde02216afab934dac3af095 upstream.

    While refactoring cgroup file removal path, 05ef1d7c4a "cgroup:
    introduce struct cfent" incorrectly changed the @dir argument of
    simple_unlink() to the inode of the file being deleted instead of that
    of the containing directory.

    The effect of this bug is minor - ctime and mtime of the parent
    weren't properly updated on file deletion.

    Fix it by using @cgrp->dentry->d_inode instead.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Reported-by: Al Viro <viro@ZenIV.linux.org.uk>
    Acked-by: Li Zefan <lizefan@huawei.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    kernel/cgroup.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/kernel/cgroup.c
    +++ b/kernel/cgroup.c
    @@ -954,7 +954,7 @@ static int cgroup_rm_file(struct cgroup

    dget(d);
    d_delete(d);
    - simple_unlink(d->d_inode, d);
    + simple_unlink(cgrp->dentry->d_inode, d);
    list_del_init(&cfe->node);
    dput(d);




    \
     
     \ /
      Last update: 2012-08-08 03:42    [W:4.182 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site