lkml.org 
[lkml]   [2012]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 007/122] powerpc/eeh: Check handle_eeh_events() return value
    Date
    From: Greg KH <gregkh@linuxfoundation.org>

    3.5-stable review patch. If anyone has any objections, please let me know.

    ------------------

    From: Kleber Sacilotto de Souza <klebers@linux.vnet.ibm.com>

    commit 10db8d212864cb6741df7d7fafda5ab6661f6f88 upstream.

    Function eeh_event_handler() dereferences the pointer returned by
    handle_eeh_events() without checking, causing a crash if NULL was
    returned, which is expected in some situations.

    This patch fixes this bug by checking for the value returned by
    handle_eeh_events() before dereferencing it.

    Signed-off-by: Kleber Sacilotto de Souza <klebers@linux.vnet.ibm.com>
    Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/powerpc/platforms/pseries/eeh_event.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    --- a/arch/powerpc/platforms/pseries/eeh_event.c
    +++ b/arch/powerpc/platforms/pseries/eeh_event.c
    @@ -85,8 +85,10 @@ static int eeh_event_handler(void * dumm
    set_current_state(TASK_INTERRUPTIBLE); /* Don't add to load average */
    edev = handle_eeh_events(event);

    - eeh_clear_slot(eeh_dev_to_of_node(edev), EEH_MODE_RECOVERING);
    - pci_dev_put(edev->pdev);
    + if (edev) {
    + eeh_clear_slot(eeh_dev_to_of_node(edev), EEH_MODE_RECOVERING);
    + pci_dev_put(edev->pdev);
    + }

    kfree(event);
    mutex_unlock(&eeh_event_mutex);



    \
     
     \ /
      Last update: 2012-08-08 01:01    [W:4.132 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site