lkml.org 
[lkml]   [2012]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] cpuidle: coupled: fix sleeping while atomic in cpu notifier
    Date
    On Wednesday, July 25, 2012, Colin Cross wrote:
    > The cpu hotplug notifier gets called in both atomic and non-atomic
    > contexts, it is not always safe to lock a mutex. Filter out all events
    > except the six necessary ones, which are all sleepable, before taking
    > the mutex.
    >
    > Signed-off-by: Colin Cross <ccross@android.com>

    Has this been applied already?

    Rafael


    > ---
    > drivers/cpuidle/coupled.c | 12 ++++++++++++
    > 1 files changed, 12 insertions(+), 0 deletions(-)
    >
    > diff --git a/drivers/cpuidle/coupled.c b/drivers/cpuidle/coupled.c
    > index 2c9bf26..c24dda0 100644
    > --- a/drivers/cpuidle/coupled.c
    > +++ b/drivers/cpuidle/coupled.c
    > @@ -678,6 +678,18 @@ static int cpuidle_coupled_cpu_notify(struct notifier_block *nb,
    > int cpu = (unsigned long)hcpu;
    > struct cpuidle_device *dev;
    >
    > + switch (action & ~CPU_TASKS_FROZEN) {
    > + case CPU_UP_PREPARE:
    > + case CPU_DOWN_PREPARE:
    > + case CPU_ONLINE:
    > + case CPU_DEAD:
    > + case CPU_UP_CANCELED:
    > + case CPU_DOWN_FAILED:
    > + break;
    > + default:
    > + return NOTIFY_OK;
    > + }
    > +
    > mutex_lock(&cpuidle_lock);
    >
    > dev = per_cpu(cpuidle_devices, cpu);
    >



    \
     
     \ /
      Last update: 2012-08-08 01:01    [W:2.367 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site