Messages in this thread | | | From | "Kim, Milo" <> | Subject | RE: [PATCH RFT] leds: lp8788: Fix updating scale configuration bits | Date | Tue, 7 Aug 2012 08:03:45 +0000 |
| |
> We need to do left shift (cfg->num + LP8788_ISINK_SCALE_OFFSET) bits > for > updating scale configuration. > > Signed-off-by: Axel Lin <axel.lin@gmail.com> > --- > Hi Milo, > Current code of updating scale configuration bits looks wrong to me > because the mask does not match the val. > I don't have this hardware, can you test this patch? > > Thanks,
The scale bits can be never updated without this patch. This patch should be applied.
Thanks for fixing this bug !
Best Regards, Milo
| |