Messages in this thread | | | Date | Tue, 7 Aug 2012 12:44:02 -0700 | Subject | Re: [PATCH] leds: triggers: send uevent when changing triggers | From | Colin Cross <> |
| |
On Tue, Aug 7, 2012 at 7:36 AM, Henrique de Moraes Holschuh <hmh@hmh.eng.br> wrote: > On Tue, 07 Aug 2012, Bryan Wu wrote: <snip>
>> Greg, Richard and Henrique, can I take you guys' Ack here? > > Yes, you have my Acked-by, provided that the uevent is NOT sent before > the led is fully registered (I cannot check right now if the patch does > this right or not. I apologise in advance if this was an unecessary > question). > > I don't care whether the uevent gets sent right after registration, or > only when the trigger *changes* after registering. But someone might, > so it would be nice to document this. > > Considering Greg's answer, maybe it would be best to resend the patch > with the point above clarified in the commit message or in the in-tree > documentation of the LED class?
led_trigger_set_default is called last from led_classdev_register, so it will send a uevent during registration but after it is fully registered. I will resend the patch with the clarification.
| |