Messages in this thread | | | Date | Tue, 7 Aug 2012 17:53:44 +0200 | From | Frederic Weisbecker <> | Subject | Re: [PATCH 1/2] perf tools: Initial bash completion support |
| |
On Tue, Aug 07, 2012 at 08:11:46AM -0600, David Ahern wrote: > On 8/7/12 7:19 AM, Frederic Weisbecker wrote: > >This implements bash completion for perf subcommands such > >as record, report, script, probe, etc... > > Love it! > > > > >Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> > >Cc: David Ahern <dsahern@gmail.com> > >Cc: Ingo Molnar <mingo@kernel.org> > >Cc: Jiri Olsa <jolsa@redhat.com> > >Cc: Namhyung Kim <namhyung@gmail.com> > >Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> > >Cc: Stephane Eranian <eranian@google.com> > >--- > > tools/perf/Makefile | 1 + > > tools/perf/bash_completion | 20 +++++++++++++ > > tools/perf/perf.c | 69 +++++++++++++++++++++++++------------------- > > 3 files changed, 60 insertions(+), 30 deletions(-) > > create mode 100644 tools/perf/bash_completion > > > >diff --git a/tools/perf/Makefile b/tools/perf/Makefile > >index 35655c3..4000d72 100644 > >--- a/tools/perf/Makefile > >+++ b/tools/perf/Makefile > >@@ -951,6 +951,7 @@ install: all > > $(INSTALL) scripts/python/Perf-Trace-Util/lib/Perf/Trace/* -t '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/scripts/python/Perf-Trace-Util/lib/Perf/Trace' > > $(INSTALL) scripts/python/*.py -t '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/scripts/python' > > $(INSTALL) scripts/python/bin/* -t '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/scripts/python/bin' > >+ $(INSTALL) -m 755 bash_completion /etc/bash_completion.d/perf > > $(DESTDIR_SQ) is need in front of the destination.
Right. Fixing this.
Thanks.
> > David
| |