Messages in this thread | | | From | (Eric W. Biederman) | Date | Tue, 07 Aug 2012 07:25:07 -0700 | Subject | Re: [PATCH] net:appletalk:ddp:fixed coding style issue again relating to |
| |
Jeffrin Jose <ahiliation@yahoo.co.in> writes:
> case TIOCINQ: { > /* > * These two are safe on a single CPU system as only > * user tasks fiddle here > */ > - struct sk_buff *skb = skb_peek(&sk->sk_receive_queue); > - long amount = 0; > + struct sk_buff *skb = skb_peek(&sk->sk_receive_queue); > + long amount = 0; > > - if (skb) > - amount = skb->len - sizeof(struct ddpehdr); > + if (skb) > + amount = skb->len - sizeof(struct ddpehdr); > rc = put_user(amount, (int __user *)argp); > break; > }
Is putting "rc = put_user(amount, (int __user *)argp);" on the same indentation level as "amount = skb->len - sizeof(struct ddpehdr);" really what you want to do?
Eric
| |