Messages in this thread | | | Date | Tue, 7 Aug 2012 11:52:26 +0100 | From | Mark Brown <> | Subject | Re: [PATCH] driver: misc: bmp085: remove "of_match_table" property. |
| |
On Tue, Aug 07, 2012 at 08:43:44AM +0300, Felipe Balbi wrote: > On Mon, Aug 06, 2012 at 04:42:14PM +0100, Mark Brown wrote:
> > It's good practice to have an explict compatible string even if the > > default happens to work in order to avoid any name clashes.
> of_i2c.c makes no use whatsoever of the compatible string. See that it > will build an i2c_boardinfo and register a new device. That compatible
If that's all that's done it seems like a bug frankly, certainly based on previous discussions it ought to be. There are collisions out there, they've just happened to not bite us yet
> string is just churn and has no use at all.
This is device tree we're talking about, there's a lot churn anyway.
| |