Messages in this thread | | | Date | Mon, 06 Aug 2012 17:48:23 -0700 | From | Randy Dunlap <> | Subject | Re: [PATCH]: BeFs parser.h support in linux kernel v3.5 |
| |
On 08/06/2012 05:07 PM, Christopher Sacchi wrote:
> This patch adds a new header, in the to-do list. There are no style issues. > Here's the patch: > -- > Signed-off-by: Christopher P. Sacchi <chris.sacchi@gmail.com> > --- befs.h 2012-07-21 20:58:29.000000000 +0000 > +++ befs.h 2012-08-06 19:52:05.000000000 +0000 > @@ -9,6 +9,7 @@ > #define _LINUX_BEFS_H > > #include "befs_fs_types.h" > +#include "linux-3.5/include/parser.h" > > /* used in debug.c */ > #define BEFS_VERSION "0.9.3" > > --
filesystem patches should also go to linux-fsdevel@vger.kernel.org .
from TODO file: * See if Alexander Viro's option parser made it into the kernel tree. Use that if we can. (include/linux/parser.h)
Yes, the option parser made it into the kernel tree several years ago, but just adding the header doesn't make befs use the option parser, so the patch is not enough. And the header patch should be:
#include <linux/parser.h>
-- ~Randy
| |