lkml.org 
[lkml]   [2012]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 2/9] rbtree: optimize fetching of sibling node
From
On Mon, Aug 6, 2012 at 7:23 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Thu, 2012-08-02 at 15:34 -0700, Michel Lespinasse wrote:
>
>> + tmp = gparent->rb_right;
>> + if (parent != tmp) { /* parent == gparent->rb_left */
>
>> + tmp = parent->rb_right;
>> + if (node == tmp) {
>
>> + tmp = parent->rb_left;
>> + if (node == tmp) {
>
>> + sibling = parent->rb_right;
>> + if (node != sibling) { /* node == parent->rb_left */
>
> Half of them got a comment, the other half didn't.. is there any
> particular reason for that?

I felt that the equality tests didn't need explanation. But the tests
where I test for inequality with the supposed sibling didn't seem
quite so obvious to me, so I commented them.

--
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.


\
 
 \ /
  Last update: 2012-08-06 23:41    [W:0.091 / U:0.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site