Messages in this thread | | | Date | Mon, 6 Aug 2012 13:46:12 -0700 | Subject | Re: [PATCH v2 2/9] rbtree: optimize fetching of sibling node | From | Michel Lespinasse <> |
| |
On Mon, Aug 6, 2012 at 7:23 AM, Peter Zijlstra <peterz@infradead.org> wrote: > On Thu, 2012-08-02 at 15:34 -0700, Michel Lespinasse wrote: > >> + tmp = gparent->rb_right; >> + if (parent != tmp) { /* parent == gparent->rb_left */ > >> + tmp = parent->rb_right; >> + if (node == tmp) { > >> + tmp = parent->rb_left; >> + if (node == tmp) { > >> + sibling = parent->rb_right; >> + if (node != sibling) { /* node == parent->rb_left */ > > Half of them got a comment, the other half didn't.. is there any > particular reason for that?
I felt that the equality tests didn't need explanation. But the tests where I test for inequality with the supposed sibling didn't seem quite so obvious to me, so I commented them.
-- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies.
| |