Messages in this thread | | | Date | Mon, 06 Aug 2012 15:22:17 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH] regulator: add MAX8907 driver |
| |
On 08/04/2012 04:19 AM, Mark Brown wrote: > On Thu, Aug 02, 2012 at 12:27:13PM -0600, Stephen Warren wrote: > >> The MAX8907 is an I2C-based power-management IC containing voltage >> regulators, a reset controller, a real-time clock, and a touch-screen >> controller.
>> +static int max8907_regulator_wled_set_current_limit(struct regulator_dev *rdev, >> + int min_uA, int max_uA) > > I'm really not convinced it makes much sense to represent the backlight > driver current regulators as regulators, they only get used as part of > the backlight and are usually tightly coupled to their boosts.
So you mean just completely remove any reference to WLED from the driver? There is a register to configure the current limit - do you not expect anything to ever need to set that in the kernel; do you expect the HW default to be correct, or the bootloader to set the desired value?
Thanks for the other parts of the review.
| |