lkml.org 
[lkml]   [2012]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] i2c: fix i2c-i801.c printk format warning
Hi Randy,

On Mon, 06 Aug 2012 09:10:47 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Fix printk format warning. ARRAY_SIZE() uses sizeof(),
> which is size_t, so use %zu to print it.
>
> drivers/i2c/busses/i2c-i801.c: In function 'i801_add_mux':
> drivers/i2c/busses/i2c-i801.c:1043:4: warning: format '%lu' expects type 'long unsigned int', but argument 3 has type 'unsigned int'
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> Cc: Mark D. Studebaker <mdsxyz123@yahoo.com>
> Cc: Jean Delvare <khali@linux-fr.org>
> ---
> drivers/i2c/busses/i2c-i801.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20120806.orig/drivers/i2c/busses/i2c-i801.c
> +++ linux-next-20120806/drivers/i2c/busses/i2c-i801.c
> @@ -1039,7 +1039,7 @@ static int __devinit i801_add_mux(struct
>
> /* Find absolute GPIO pin numbers */
> if (ARRAY_SIZE(priv->mux_priv) < mux_config->n_gpios) {
> - dev_err(dev, "i801_priv.mux_priv too small (%lu, need %d)\n",
> + dev_err(dev, "i801_priv.mux_priv too small (%zu, need %d)\n",
> ARRAY_SIZE(priv->mux_priv), mux_config->n_gpios);
> return -ENODEV;
> }

Good catch once again, thanks a lot. As the offending patch is still
not upstream, I've folded your fix into it.

--
Jean Delvare


\
 
 \ /
  Last update: 2012-08-06 19:01    [W:0.056 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site