| Subject | Re: [PATCH v2 8/9] rbtree: faster augmented rbtree manipulation | From | Peter Zijlstra <> | Date | Mon, 06 Aug 2012 16:29:28 +0200 |
| |
On Thu, 2012-08-02 at 15:34 -0700, Michel Lespinasse wrote: > +void __rb_insert_augmented(struct rb_node *node, struct rb_root *root, > + void (*augment_rotate)(struct rb_node *old, struct rb_node *new)) > +{ > + __rb_insert(node, root, augment_rotate); > +} > +EXPORT_SYMBOL(__rb_insert_augmented); > + > +void rb_erase_augmented(struct rb_node *node, struct rb_root *root, > + const struct rb_augment_callbacks *augment) > +{ > + __rb_erase(node, root, augment); > +} > +EXPORT_SYMBOL(rb_erase_augmented);
From a symmetry POV I'd say have both take the rb_augment_callbacks thing. The two taking different arguments is confusing at best.
|