Messages in this thread | | | Date | Mon, 06 Aug 2012 14:42:28 +0200 | From | Tomasz Stanislawski <> | Subject | Re: [PATCH 2/2] dma-buf: add helpers for attacher dma-parms |
| |
On 08/06/2012 01:58 PM, Michal Nazarewicz wrote: > > Tomasz Stanislawski <t.stanislaws@samsung.com> writes: >> I recommend to change the semantics for unlimited number of segments >> from 'value 0' to: >> >> #define DMA_SEGMENTS_COUNT_UNLIMITED ((unsigned long)INT_MAX)
Sorry. It should be: #define DMA_SEGMENTS_COUNT_UNLIMITED ((unsigned int)INT_MAX)
>> >> Using INT_MAX will allow using safe conversions between signed and >> unsigned integers. > > LONG_MAX seems cleaner regardless. > > >
| |