Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH v6 6/8] fsl-dma: use spin_lock_bh to instead of spin_lock_irqsave | Date | Mon, 6 Aug 2012 11:57:17 +0000 |
| |
On Monday 06 August 2012, qiang.liu@freescale.com wrote: > > From: Qiang Liu <qiang.liu@freescale.com> > > The use of spin_lock_irqsave() is a stronger locking mechanism than is > required throughout the driver. The minimum locking required should be > used instead. Interrupts will be turned off and context will be saved, > there is needless to use irqsave. > > Change all instances of spin_lock_irqsave() to spin_lock_bh(). > All manipulation of protected fields is done using tasklet context or > weaker, which makes spin_lock_bh() the correct choice. > > Cc: Dan Williams <dan.j.williams@intel.com> > Cc: Dan Williams <dan.j.williams@gmail.com> > Cc: Vinod Koul <vinod.koul@intel.com> > Cc: Li Yang <leoli@freescale.com> > Cc: Timur Tabi <timur@freescale.com> > Signed-off-by: Qiang Liu <qiang.liu@freescale.com> > Acked-by: Ira W. Snyder <iws@ovro.caltech.edu>
Acked-by: Arnd Bergmann <arnd@arndb.de>
You could actually change the use of spin_lock_bh inside of the tasklet function (dma_do_tasklet) do just spin_lock(), because softirqs are already disabled there, but your version is also ok.
| |