Messages in this thread | | | Date | Mon, 06 Aug 2012 02:15:17 +0000 (GMT) | From | 함명주 <> | Subject | Re: [PATCH] Extcon: adc_jack: adc-jack driver to support 3.5 pi or simliar devices |
| |
> From: anish kumar <anish198519851985@gmail.com> > > External connector devices that decides connection information based on > ADC values may use adc-jack device driver. The user simply needs to > provide a table of adc range and connection states. Then, extcon > framework will automatically notify others. > > Signed-off-by: anish kumar <anish.singh@samsung.com>
- Please remove "get_adc" callbacks still remaining in the header file (and its comments)
- Let's not modify un-related driver code (in Kconfig, extcon-gpio)
Except that, things look good.
Cheers MyungJoo
| |