Messages in this thread Patch in this message | | | From | Ming Lei <> | Subject | [RFC PATCH v1 03/15] firmware loader: remove unnecessary wmb() | Date | Sat, 4 Aug 2012 12:01:18 +0800 |
| |
The wmb() inside fw_load_abort is not necessary, since complete() and wait_on_completion() has implied one pair of memory barrier.
Also wmb() isn't a correct usage, so just remove it.
Signed-off-by: Ming Lei <ming.lei@canonical.com> --- drivers/base/firmware_class.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c index 1915ad8..0bd09c7 100644 --- a/drivers/base/firmware_class.c +++ b/drivers/base/firmware_class.c @@ -112,7 +112,6 @@ static struct firmware_priv *to_firmware_priv(struct device *dev) static void fw_load_abort(struct firmware_priv *fw_priv) { set_bit(FW_STATUS_ABORT, &fw_priv->status); - wmb(); complete(&fw_priv->completion); } -- 1.7.9.5
| |