lkml.org 
[lkml]   [2012]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 07/22] ARM: LPAE: use phys_addr_t in free_memmap()
On Tue, 31 Jul 2012, Cyril Chemparathy wrote:

> From: Vitaly Andrianov <vitalya@ti.com>
>
> The free_memmap() was mistakenly using unsigned long type to represent
> physical addresses. This breaks on PAE systems where memory could be placed
> above the 32-bit addressible limit.
>
> This patch fixes this function to properly use phys_addr_t instead.
>
> Signed-off-by: Vitaly Andrianov <vitalya@ti.com>
> Signed-off-by: Cyril Chemparathy <cyril@ti.com>

Acked-by: Nicolas Pitre <nico@linaro.org>

> ---
> arch/arm/mm/init.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
> index f54d592..8252c31 100644
> --- a/arch/arm/mm/init.c
> +++ b/arch/arm/mm/init.c
> @@ -457,7 +457,7 @@ static inline void
> free_memmap(unsigned long start_pfn, unsigned long end_pfn)
> {
> struct page *start_pg, *end_pg;
> - unsigned long pg, pgend;
> + phys_addr_t pg, pgend;
>
> /*
> * Convert start_pfn/end_pfn to a struct page pointer.
> @@ -469,8 +469,8 @@ free_memmap(unsigned long start_pfn, unsigned long end_pfn)
> * Convert to physical addresses, and
> * round start upwards and end downwards.
> */
> - pg = (unsigned long)PAGE_ALIGN(__pa(start_pg));
> - pgend = (unsigned long)__pa(end_pg) & PAGE_MASK;
> + pg = PAGE_ALIGN(__pa(start_pg));
> + pgend = __pa(end_pg) & PAGE_MASK;
>
> /*
> * If there are free pages between these,
> --
> 1.7.9.5
>


\
 
 \ /
  Last update: 2012-08-04 09:41    [W:0.315 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site