Messages in this thread | | | Date | Sat, 4 Aug 2012 21:43:05 +0200 | From | Jean Delvare <> | Subject | Re: [PATCH] drivers/i2c/i2c-smbus.c: convert kzalloc to devm_kzalloc |
| |
Hi Julia,
On Sat, 4 Aug 2012 19:10:48 +0200, Julia Lawall wrote: > From: Julia Lawall <Julia.Lawall@lip6.fr> > > Converting kzalloc to devm_kzalloc simplifies the code and ensures that the > result, alert, is freed after the irq allocated by the subsequent > devm_request_irq. This in turn ensures that when an interrupt can be > triggered, the alert structure is still available.
Good point. I honestly have no idea why this driver's resources are half managed, it doesn't make much sense...
Patch applied, with a comment clarified, thanks.
-- Jean Delvare
| |