Messages in this thread | | | Date | Fri, 31 Aug 2012 15:41:28 -0700 | From | Dmitry Torokhov <> | Subject | Re: [PATCH v2] drivers/tty: Folding Android's keyreset driver in sysRQ |
| |
On Fri, Aug 31, 2012 at 11:02:27PM +0100, Alan Cox wrote: > > > Why do we need to involve a platform device and not use, for example, a module > > > parameter, that could be set up from userspace? > > > > The platform device comes from the original design and was included to > > minimise the amount of changes in code that make use of the current > > keyreset driver. > > The platform device is IMHO the right answer. In this class of devices > the stuff is compiled in, the userspace is Android, there are no modules > and there is no reason for it to be configurable.
It does not matter if it is built in or not, /sys/module/XXX/parameters is still there, and while havig it in kernel is "easy" you could as easily stuff needed data into a sysfs attribute during booting.
And we should be able to get this from DT even without the platform device (this was the next step, wasn't it?).
Thanks.
-- Dmitry
| |