lkml.org 
[lkml]   [2012]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject[PATCH 0/4] Fix a crash when block device is read and block size is changed at the same time
Hi

This is a series of patches to prevent a crash when when someone is
reading block device and block size is changed simultaneously. (the crash
is already happening in the production environment)

The first patch adds a rw-lock to struct block_device, but doesn't use the
lock anywhere. The reason why I submit this as a separate patch is that on
my computer adding an unused field to this structure affects performance
much more than any locking changes.

The second patch uses the rw-lock. The lock is locked for read when doing
I/O on the block device and it is locked for write when changing block
size.

The third patch converts the rw-lock to a percpu rw-lock for better
performance, to avoid cache line bouncing.

The fourth patch is an alternate percpu rw-lock implementation using RCU
by Eric Dumazet. It avoids any atomic instruction in the hot path.

Mikulas


\
 
 \ /
  Last update: 2012-08-31 21:21    [W:0.076 / U:1.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site