Messages in this thread | | | Date | Fri, 31 Aug 2012 10:10:37 -0600 | From | David Ahern <> | Subject | Re: [PATCH] [perf] Fix intlist node removal |
| |
On 8/31/12 12:58 AM, Suzuki K. Poulose wrote: > Similar to the one in : > https://lkml.org/lkml/2012/8/29/27 > > > Make sure we remove the node from the rblist before we delete the > node. The rblist__remove_node() will invoke rblist->node_delete, > which will take care of deleting the node with the suitable function > provided by the user. > > Signed-off-by: Suzuki K Poulose <suzuki@in.ibm.com> > Cc: David Ahern <dsahern@gmail.com> > --- > > tools/perf/util/intlist.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/util/intlist.c b/tools/perf/util/intlist.c > index fd530dc..77c504f 100644 > --- a/tools/perf/util/intlist.c > +++ b/tools/perf/util/intlist.c > @@ -52,9 +52,9 @@ int intlist__add(struct intlist *ilist, int i) > return rblist__add_node(&ilist->rblist, (void *)((long)i)); > } > > -void intlist__remove(struct intlist *ilist __used, struct int_node *node) > +void intlist__remove(struct intlist *ilist, struct int_node *node) > { > - int_node__delete(node); > + rblist__remove_node(&ilist->rblist, &node->rb_node); > } > > struct int_node *intlist__find(struct intlist *ilist, int i) >
Acked-by: David Ahern <dsahern@gmail.com>
| |