Messages in this thread | | | Date | Thu, 30 Aug 2012 05:07:48 -0700 | From | Anton Vorontsov <> | Subject | Re: [PATCH 4/8] lp8727_charger: cleanup the interrupt handler code |
| |
On Thu, Aug 30, 2012 at 11:39:57AM +0000, Kim, Milo wrote: > (a) add configurable debounce timer in the platform data > : if it is not defined, default time(270ms) is set. > (b) use schedule_delay_work() and remove unnecessary workqueue resource > : for delayed interrupt handling, use the schedule_delay_work() > (c) add lp8727_release_irq() for clearing the irq > (c) clear interrupts while loading the driver
It seems to me that all of the issues desire their own separate patches. A few benefits for this:
- It helps reviewing changes; - In case of regressions, that would help bisecting a lot, plus we will not need to revert the whole thing, if we'd have to fall back to revert.
Thanks, Anton.
| |