lkml.org 
[lkml]   [2012]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/2] linux/kernel.h: Introduce IDIV_ROUND_CLOSEST
On Thu, Aug 30, 2012 at 04:15:32PM -0700, Andrew Morton wrote:
> On Tue, 28 Aug 2012 09:30:55 -0700
> Guenter Roeck <linux@roeck-us.net> wrote:
>
> > DIV_ROUND_CLOSEST returns a bad result for negative dividends:
> > DIV_ROUND_CLOSEST(-2, 2) = 0
> >
> > Most of the time this does not matter. However, in the hardware monitoring
> > subsystem, it is sometimes used on integers which can be negative (such as
> > temperatures). Introduce new macro IDIV_ROUND_CLOSEST which also supports
> > negative dividends.
> >
>
> Can't we just fix DIV_ROUND_CLOSEST? That will make it a bit slower
> but it's not exactly a speed demon right now. And fixing
> DIV_ROUND_CLOSEST() might just fix other bugs that we don't know about
> yet.
>
Sure, fine with me. I'll submit a patch. Let's see who starts screaming.

Guenter


\
 
 \ /
  Last update: 2012-08-31 02:21    [W:0.049 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site