Messages in this thread | | | Date | Thu, 30 Aug 2012 17:22:02 -0400 (EDT) | From | Vivien Didelot <> | Subject | Re: [PATCH] hwmon: add Maxim MAX197 support |
| |
I guess we're too fast!
I've just seen your reply, this is much cleaner, indeed. I'll update the max197 driver, and fix the sht15 driver as soon as I can.
Thanks, Vivien
----- Mail original ----- De: "Guenter Roeck" <linux@roeck-us.net> À: "Vivien Didelot" <vivien.didelot@savoirfairelinux.com> Cc: lm-sensors@lm-sensors.org, "Jean Delvare" <khali@linux-fr.org>, linux-kernel@vger.kernel.org Envoyé: Jeudi 30 Août 2012 17:14:44 Objet: Re: [PATCH] hwmon: add Maxim MAX197 support
On Thu, Aug 30, 2012 at 05:10:32PM -0400, Vivien Didelot wrote: > Hi Guenter, > > Thanks for your detailed comments. I'll send a new version soon. > > About the following comment, I agree with you. However as there is no convention for this case, for now I would prefer to stick with the model as seen in drivers such as sht15. > Actually, there is a convention, and it is much cleaner than using multiple platform driver instances. I sent you a separate e-mail a minute ago, describing how it works.
We should actually fix the sht15 driver as well to use the same approach.
Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |