lkml.org 
[lkml]   [2012]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC v2 7/7] net,9p: use new hashtable implementation
On 08/03/2012 08:00 PM, Eric Dumazet wrote:
> On Fri, 2012-08-03 at 16:23 +0200, Sasha Levin wrote:
>> /* initialize hash table */
>> - for (bucket = 0; bucket < ERRHASHSZ; bucket++)
>> - INIT_HLIST_HEAD(&hash_errmap[bucket]);
>> + hash_init(&hash_errmap, ERRHASHSZ);
>
> Why is hash_init() even needed ?
>
> If hash is "DEFINE_STATIC_HASHTABLE(...)", its already ready for use !

Indeed it is.

I've removed it, and then decided to put it back since the definition of the hashtable isn't fully cooked yet, and I didn't want to miss this initialization point if it turn out we need to initialize that hashtable afterall.

I will remove it once the hashtable definitions are clear.

The rest of the review comments will be addressed.

Thanks!


\
 
 \ /
  Last update: 2012-08-04 00:01    [W:0.209 / U:0.864 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site