lkml.org 
[lkml]   [2012]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [ 33/73] x86, microcode: Sanitize per-cpu microcode reloading interface
    On Fri, Aug 03, 2012 at 11:04:06AM +0200, Sven Joachim wrote:
    > On 2012-07-31 06:43 +0200, Ben Hutchings wrote:
    >
    > > 3.2-stable review patch. If anyone has any objections, please let me know.
    >
    > Alas, this does not build if CONFIG_SMP is unset:
    >
    > ,----
    > | arch/x86/kernel/microcode_core.c: In function 'reload_store':
    > | arch/x86/kernel/microcode_core.c:304:19: error: 'struct cpuinfo_x86' has no member named 'cpu_index'
    > `----

    Crap. :-(

    3.2 still has this:

    <arch/x86/include/asm/processor.h>:
    ...
    #ifdef CONFIG_SMP
    /* number of cores as seen by the OS: */
    u16 booted_cores;
    /* Physical processor id: */
    u16 phys_proc_id;
    /* Core id: */
    u16 cpu_core_id;
    /* Compute unit id */
    u8 compute_unit_id;
    /* Index into per_cpu list: */
    u16 cpu_index;
    #endif
    u32 microcode;
    } __attribute__((__aligned__(SMP_CACHE_BYTES)));
    ---

    which got removed by

    commit 141168c36cdee3ff23d9c7700b0edc47cb65479f
    Author: Kevin Winchester <kjwinchester@gmail.com>
    Date: Tue Dec 20 20:52:22 2011 -0400

    x86: Simplify code by removing a !SMP #ifdefs from 'struct cpuinfo_x86'

    Ben, you might want to backport this one too... I'll run a couple of 3.2
    builds with it ontop of 3.2 to verify nothing else breaks.

    Thanks.

    --
    Regards/Gruss,
    Boris.

    Advanced Micro Devices GmbH
    Einsteinring 24, 85609 Dornach
    GM: Alberto Bozzo
    Reg: Dornach, Landkreis Muenchen
    HRB Nr. 43632 WEEE Registernr: 129 19551


    \
     
     \ /
      Last update: 2012-08-03 12:41    [W:4.135 / U:1.972 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site