Messages in this thread | | | Subject | Re: [PATCH 3.6-rc3] wlcore: Declare MODULE_FIRMWARE usage | From | Luciano Coelho <> | Date | Wed, 29 Aug 2012 21:57:48 +0300 |
| |
On Wed, 2012-08-29 at 11:13 -0600, Tim Gardner wrote: > On 08/29/2012 11:01 AM, Luciano Coelho wrote: > > On Wed, 2012-08-29 at 08:48 -0600, Tim Gardner wrote: > >> Cc: Luciano Coelho <coelho@ti.com> > >> Cc: "John W. Linville" <linville@tuxdriver.com> > >> Cc: Eliad Peller <eliad@wizery.com> > >> Cc: Arik Nemtsov <arik@wizery.com> > >> Cc: Eyal Shapira <eyal@wizery.com> > >> Cc: linux-wireless@vger.kernel.org > >> Cc: netdev@vger.kernel.org > >> Signed-off-by: Tim Gardner <tim.gardner@canonical.com> > >> --- > > > > Please add a proper commit message. And there's no need to put all > > these people in Cc: in the commit log. CC'ing when sending the patch is > > enough (even though for such small patch, the linux-wireless mailing > > list and myself is enough). > > > > -- > > Luca. > > > > What more would you like covered in the commit message that isn't > obvious from the subject?
It's obvious from the subject, indeed. But commits with no descriptions are ugly. Add something, for example a small "why" would be nice.
> The Cc list comes from scripts/get_maintainers.pl as suggested by > Documentation/SubmittingPatches: "5) Select e-mail destination."
Yeah, that's correct, but it doesn't mean you should put them as Cc: tags in the commit log. CCing when *sending* the email only is enough. Most people won't really care for the entire lifetime of this patch. And, come on, the Cc tags take more space than the actual patch.
-- Luca.
| |