Messages in this thread | | | Subject | Re: [PATCH 4/7] net/bluetooth/rfcomm/core.c: fix error return code | From | Marcel Holtmann <> | Date | Wed, 29 Aug 2012 11:23:29 -0700 |
| |
Hi Julia,
> Initialize return variable before exiting on an error path. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // <smpl> > ( > if@p1 (\(ret < 0\|ret != 0\)) > { ... return ret; } > | > ret@p1 = 0 > ) > ... when != ret = e1 > when != &ret > *if(...) > { > ... when != ret = e2 > when forall > return ret; > } > > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > --- > net/bluetooth/rfcomm/core.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-)
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Regards
Marcel
| |