Messages in this thread | | | Date | Tue, 28 Aug 2012 12:14:52 +0100 | From | "Richard W.M. Jones" <> | Subject | Re: [PATCH] block: replace __getblk_slow misfix by grow_dev_page fix |
| |
On Wed, Aug 22, 2012 at 09:56:12PM -0700, Hugh Dickins wrote: > On Wed, 22 Aug 2012, Richard W.M. Jones wrote: > > On Tue, Aug 21, 2012 at 06:33:45PM -0700, Hugh Dickins wrote: > > > Jeff, > > > > > > Your commit 91f68c89d8f3 ("block: fix infinite loop in __getblk_slow"), > > > already gone into 3.* stable, is not good. Could you and your testers > > > please give this alternative a try - I think it should work, and have > > > started it on a few days' memory load on 3.5, but not tried your case. > > > > I have tested your patch and it does NOT fix the problem in > > http://bugzilla.redhat.com/835019 > > Kernel 3.6.0 + your patch => mount goes into a loop when mounting > > a small empty partition. Please do NOT apply this as it will > > cause a regression! > > That was all very helpful information that you provided, thank you. > Sorry, I had missed how "block" is massaged as it's passed down a level. > > The patch below fixes it for me, though it does have to change more than > I'd been hoping in such a fix. Perhaps I am just being silly to resist > repeating the call to blkdev_max_block(). Does this patch work for you? > > Thanks, > Hugh > > [PATCH] block: replace __getblk_slow misfix by grow_dev_page fix
I noticed this (second version) went upstream already. Nevertheless I tested it today and it doesn't cause a regression of RHBZ#835019.
Thanks,
Rich.
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org
| |