lkml.org 
[lkml]   [2012]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v7 7/9] block: Add bio_clone_bioset(), bio_clone_kmalloc()
    On Tue, Aug 28, 2012 at 10:37:34AM -0700, Kent Overstreet wrote:
    > +static inline struct bio *bio_clone(struct bio *bio, gfp_t gfp_mask)
    > +{
    > + return bio_clone_bioset(bio, gfp_mask, fs_bio_set);
    > +}
    > +
    ...
    > +static inline struct bio *bio_clone_kmalloc(struct bio *bio, gfp_t gfp_mask)
    > +{
    > + return bio_clone_bioset(bio, gfp_mask, NULL);
    > +
    > +}

    Do we really need these wrappers? I'd prefer requiring users to
    explicit choose @bioset when cloning.

    Thanks.

    --
    tejun


    \
     
     \ /
      Last update: 2012-08-28 23:21    [W:5.105 / U:0.272 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site