Messages in this thread | | | Date | Tue, 28 Aug 2012 13:44:01 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH v7 7/9] block: Add bio_clone_bioset(), bio_clone_kmalloc() |
| |
On Tue, Aug 28, 2012 at 10:37:34AM -0700, Kent Overstreet wrote: > +static inline struct bio *bio_clone(struct bio *bio, gfp_t gfp_mask) > +{ > + return bio_clone_bioset(bio, gfp_mask, fs_bio_set); > +} > + ... > +static inline struct bio *bio_clone_kmalloc(struct bio *bio, gfp_t gfp_mask) > +{ > + return bio_clone_bioset(bio, gfp_mask, NULL); > + > +}
Do we really need these wrappers? I'd prefer requiring users to explicit choose @bioset when cloning.
Thanks.
-- tejun
| |