lkml.org 
[lkml]   [2012]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH] block: Fix bad range check in bio_sector_offset
From
Date

DM would occasionally end up splitting data integrity-enabled requests
incorrectly. The culprit was a bad range check in bio_sector_offset.

Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Cc: <stable@vger.kernel.org>

diff --git a/fs/bio.c b/fs/bio.c
index 9bfade8..b9a6744 100644
--- a/fs/bio.c
+++ b/fs/bio.c
@@ -1552,8 +1552,8 @@ sector_t bio_sector_offset(struct bio *bio, unsigned short index,
sector_sz = queue_logical_block_size(bio->bi_bdev->bd_disk->queue);
sectors = 0;

- if (index >= bio->bi_idx)
- index = bio->bi_vcnt - 1;
+ if (index > bio->bi_vcnt)
+ return 0;

__bio_for_each_segment(bv, bio, i, 0) {
if (i == index) {

\
 
 \ /
  Last update: 2012-08-28 20:41    [W:0.042 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site