lkml.org 
[lkml]   [2012]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 06/14] aoe: failover remote interface based on aoe_deadsecs parameter
    The aoe_deadsecs module parameter allows the user to specify a hard
    limit on the number of seconds an AoE command can be retransmitted
    before the AoE block device is considered to have failed.

    Using aoe_deadsecs to determine the time we try using a different
    remote interface helps to ensure that the hard limit is not reached
    before we've tried to recover by sending to a different remote port.

    As a data storage target, the AoE target is unambiguously identified
    by its {major, minor} AoE address tuple, and an AoE target can have
    multiple MAC addresses. However, note that "target" in the driver
    code and comments means a {major, minor, MAC address} tuple, as in
    "somewhere to send packets".

    Signed-off-by: Ed Cashin <ecashin@coraid.com>
    ---
    drivers/block/aoe/aoe.h | 1 -
    drivers/block/aoe/aoecmd.c | 8 +++-----
    2 files changed, 3 insertions(+), 6 deletions(-)

    diff --git a/drivers/block/aoe/aoe.h b/drivers/block/aoe/aoe.h
    index ffded64..d17b727 100644
    --- a/drivers/block/aoe/aoe.h
    +++ b/drivers/block/aoe/aoe.h
    @@ -96,7 +96,6 @@ enum {
    TIMERTICK = HZ / 10,
    MINTIMER = HZ >> 2,
    MAXTIMER = HZ << 1,
    - HELPWAIT = 20,
    };

    struct buf {
    diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c
    index cf196ed..7f9cc44 100644
    --- a/drivers/block/aoe/aoecmd.c
    +++ b/drivers/block/aoe/aoecmd.c
    @@ -632,11 +632,9 @@ rexmit_timer(ulong vp)
    list_del(pos);

    t = f->t;
    - if (n > HELPWAIT) {
    - /* see if another target can help */
    - if (d->ntargets > 1)
    - d->htgt = t;
    - }
    + if (n > aoe_deadsecs/2)
    + d->htgt = t; /* see if another target can help */
    +
    if (t->nout == t->maxout) {
    if (t->maxout > 1)
    t->maxout--;
    --
    1.7.2.5


    \
     
     \ /
      Last update: 2012-08-28 16:21    [W:4.543 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site