lkml.org 
[lkml]   [2012]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] perf tools: Fix a misuse of for_each_set_bit() in session.c
Hi,

On Mon, 27 Aug 2012 16:59:07 +0900
Namhyung Kim <namhyung@kernel.org> wrote:

> Hi,
>
> On Mon, 27 Aug 2012 15:38:27 +0800, Feng Tang wrote:
> > In regs_dump__printf() it use for_each_set_bit() for bit ops by
> > casting a (u64 *) to a (unsigned long *), this works for 64 bits
> > machine, but will fail on 32 bits ones.
> >
> > Fix it by using the raw bit comparing method.
>
> Did it really cause a build failure or a program error? If not, it
> looks better to keep using for_each_set_bit() interface. How about
> casting the @mask to (void *) ?

It's a compile error:

cc1: warnings being treated as errors
util/session.c: In function ‘perf_session_deliver_event’:
util/include/linux/bitops.h:104: error: dereferencing pointer ‘p’ does break strict-aliasing rules
util/include/linux/bitops.h:96: error: dereferencing pointer ‘p’ does break strict-aliasing rules
util/session.c:907: note: initialized from here
util/include/linux/bitops.h:96: note: initialized from here
make: *** [util/session.o] Error 1
make: *** Waiting for unfinished jobs....

Casting the @mask to (void *) still sees the same error

Thanks,
Feng
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-08-27 11:01    [W:0.079 / U:1.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site