| Date | Mon, 27 Aug 2012 16:05:21 -0700 | Subject | Re: [RFC PATCH 00/11] input: Synaptics RMI4 Touchscreen Driver | From | Linus Walleij <> |
| |
On Fri, Aug 17, 2012 at 3:17 PM, Christopher Heiny <cheiny@synaptics.com> wrote:
> This patch implements a driver supporting Synaptics ClearPad and other > touchscreen sensors that use the RMI4 protocol, as defined here:
OK I looked over the parts I understood, to my surprise there is a custom GPIO, LED and ADC driver in there, and none of them use the proper kernel subsystems.
You may want to expose the bus in <linux/input/rmi4.h> or so, and put the drivers for these into e.g.
drivers/gpio/gpio-rmi4.c drivers/leds/leds-rmi4.c drivers/iio/adc/rmi4.c
Which would be nice. (Kconfig can make sure they're only available when enabling the bus.)
As for the input stuff I mainly looked at the stuff I understand...
Yours, Linus Walleij
|