| Date | Mon, 27 Aug 2012 16:01:52 -0700 | Subject | Re: [RFC PATCH 17/17] input: RMI4 F54 analog data reporting | From | Linus Walleij <> |
| |
On Fri, Aug 17, 2012 at 3:17 PM, Christopher Heiny <cheiny@synaptics.com> wrote:
Verbose commit message.
> Signed-off-by: Christopher Heiny <cheiny@synaptics.com>
> +#include <linux/hrtimer.h> > +#include <linux/kernel.h> > +#include <linux/rmi.h> > +#include <linux/slab.h> > +#include <linux/version.h> > +#include <linux/delay.h>
This is not using the existing in-kernel framework for ADC (which I think is what you're doing), in this case use the IIO subsystem so consult drivers/iio/adc and be inspired.
Just exposing a set of weird sysfs files to userspace is not proper.
Yours, Linus Walleij
|