Messages in this thread | | | Date | Mon, 27 Aug 2012 13:07:25 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH 7/7] workqueue: static idle_rebind |
| |
Hello, Lai.
On Tue, Aug 28, 2012 at 01:58:27AM +0800, Lai Jiangshan wrote: > rebind_workers() is protected by cpu_hotplug lock, > so struct idle_rebind is also proteced by it. > > And we can use a compile time allocated idle_rebind instead > of allocating it from the stack. it makes code clean.
I don't know. While it seems correct, depending on outer locking makes things more fragile and the dependency is implicit. I'd rather keep it separate.
Thanks.
-- tejun
| |