lkml.org 
[lkml]   [2012]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/7] workqueue: single pass rebind_workers
Hello, Lai.

On Tue, Aug 28, 2012 at 01:58:24AM +0800, Lai Jiangshan wrote:
> busy_worker_rebind_fn() can't return until all idle workers are rebound,
> the code of busy_worker_rebind_fn() ensure this.
>
> So we can change the order of the code of rebind_workers(),
> and make it a single pass do the rebind_workers().
>
> It makes the code much clean and better readability.

I can't see how this could be correct. What prevents busy worker from
grabbing manager_mutex before idle one?

Thanks.

--
tejun


\
 
 \ /
  Last update: 2012-08-27 21:41    [W:0.097 / U:1.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site