Messages in this thread | | | Date | Mon, 27 Aug 2012 12:04:31 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH 4/7] workqueue: single pass rebind_workers |
| |
Hello, Lai.
On Tue, Aug 28, 2012 at 01:58:24AM +0800, Lai Jiangshan wrote: > busy_worker_rebind_fn() can't return until all idle workers are rebound, > the code of busy_worker_rebind_fn() ensure this. > > So we can change the order of the code of rebind_workers(), > and make it a single pass do the rebind_workers(). > > It makes the code much clean and better readability.
I can't see how this could be correct. What prevents busy worker from grabbing manager_mutex before idle one?
Thanks.
-- tejun
| |