Messages in this thread | | | Date | Mon, 27 Aug 2012 09:50:57 -0700 | From | Mark Brown <> | Subject | Re: [NEW DRIVER V3 8/8] DA9058 REGULATOR driver |
| |
On Wed, Aug 15, 2012 at 04:05:25PM +0100, Anthony Olech wrote:
> +static int da9058_buck_ramp_voltage(struct regulator_dev *rdev, > + unsigned int old_selector, > + unsigned int new_selector) > +{
> + ret = da9058_set_bits(da9058, regulator->ramp_register, > + regulator->ramp_enable_mask); > + > + if (ret) > + return ret;
> + return 2200; /* micro Seconds needed to ramp to new voltage*/
Why is this function writing to the hardware, especially writing the same value every time?
> +static int da9058_get_fixed_regulator_voltage(struct regulator_dev *rdev) > +{ > + struct da9058_regulator *regulator = rdev_get_drvdata(rdev); > + > + if (regulator_is_enabled_regmap(rdev)) > + return regulator->fixed_voltage; > + else > + return 0; > +}
list_voltage_linear()
| |