Messages in this thread | | | Date | Mon, 27 Aug 2012 21:31:11 +0530 | From | "Naveen N. Rao" <> | Subject | Re: [PATCH 1/2] x86/mce: Pack boolean MCE boot flags into a structure |
| |
On 08/27/2012 09:17 PM, Borislav Petkov wrote: > On Mon, Aug 27, 2012 at 09:05:46PM +0530, Naveen N. Rao wrote: >>>> + >>>> +extern struct mce_boot_flags mce_boot_flags; >>> >>> Why do we need that extern thing? >> >> So that this is visible across mce.c and mce_intel.c? > > Ok. But if you move the struct to mce-internal.h and since both .c files > include it, we shouldn't need that extern, right?
I'm not sure I understand. I think we still need it. This is not about the structure, but the variable itself. extern allows mce_boot_flags _variable_ accessible from mce_intel.c.
Thanks, Naveen
> > I think that'll be the most optimal placement for now. > > Thanks. >
| |