Messages in this thread | | | Date | Mon, 27 Aug 2012 17:47:41 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 1/2] x86/mce: Pack boolean MCE boot flags into a structure |
| |
On Mon, Aug 27, 2012 at 09:05:46PM +0530, Naveen N. Rao wrote: > >>+ > >>+extern struct mce_boot_flags mce_boot_flags; > > > >Why do we need that extern thing? > > So that this is visible across mce.c and mce_intel.c?
Ok. But if you move the struct to mce-internal.h and since both .c files include it, we shouldn't need that extern, right?
I think that'll be the most optimal placement for now.
Thanks.
-- Regards/Gruss, Boris.
Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551
| |