lkml.org 
[lkml]   [2012]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/2] fat : no need to reset EOF in ent_put for FAT32
Date
Namjae Jeon <linkinjeon@gmail.com> writes:

> #define FAT_ENT_EOF(EOF_FAT32)
>
> there is no need to reset value of 'new' for FAT32 as the values is
> already correct
>
> Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
> Signed-off-by: Amit Sahrawat <amit.sahrawat83@gmail.com>
> ---
> fs/fat/fatent.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/fat/fatent.c b/fs/fat/fatent.c
> index 31f08ab..af53815 100644
> --- a/fs/fat/fatent.c
> +++ b/fs/fat/fatent.c
> @@ -186,8 +186,6 @@ static void fat16_ent_put(struct fat_entry *fatent, int new)
>
> static void fat32_ent_put(struct fat_entry *fatent, int new)
> {
> - if (new == FAT_ENT_EOF)
> - new = EOF_FAT32;
>

Please remove this new line too. If it was removed,

Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

> WARN_ON(new & 0xf0000000);
> new |= le32_to_cpu(*fatent->u.ent32_p) & ~0x0fffffff;

--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>


\
 
 \ /
  Last update: 2012-08-26 16:41    [W:0.044 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site