Messages in this thread | | | Date | Sun, 26 Aug 2012 17:31:13 +0800 | From | Fengguang Wu <> | Subject | Re: fs/ntfs/super.c:2717:1-14: alloc with no test |
| |
On Sun, Aug 26, 2012 at 02:42:12PM +0530, devendra.aaru wrote: > On Sun, Aug 26, 2012 at 2:34 PM, Fengguang Wu <fengguang.wu@intel.com> wrote: > > > > Hi Anton, > > > > FYI, coccinelle warns about > > > > fs/ntfs/super.c:2717:1-14: alloc with no test, possible model on line 2718 > > > > vim +2717 fs/ntfs/super.c > > 2714 sb->s_flags |= MS_RDONLY; > > 2715 #endif /* ! NTFS_RW */ > > 2716 /* Allocate a new ntfs_volume and place it in sb->s_fs_info. */ > >> 2717 sb->s_fs_info = kmalloc(sizeof(ntfs_volume), GFP_NOFS); > > That's i think a false alarm. > > > 2718 vol = NTFS_SB(sb); > > The NTFS_SB(buf) { > buf->s_fs_info; > } > > so we are validating the allocated pointer s_fs_info.
Yes, it is. Sorry for the noise!
Thanks, Fengguang
| |