Messages in this thread | | | Date | Sun, 26 Aug 2012 20:30:30 +0200 | From | Sebastian Andrzej Siewior <> | Subject | Re: [PATCH 16/19] x86, irq: Introduce setup_remapped_irq() |
| |
On Mon, Aug 20, 2012 at 03:56:02PM +0200, Joerg Roedel wrote: > --- a/arch/x86/include/asm/irq_remapping.h > +++ b/arch/x86/include/asm/irq_remapping.h > @@ -44,6 +44,9 @@ extern void compose_remapped_msi_msg(struct pci_dev *pdev, > struct msi_msg *msg, u8 hpet_id); > extern int setup_hpet_msi_remapped(unsigned int irq, unsigned int id); > extern void panic_if_irq_remap(const char *msg); > +extern bool setup_remapped_irq(int irq, > + struct irq_cfg *cfg, > + struct irq_chip *chip); here and in the next definition, is it possible to fit it in one line or alteast in two?
> > static inline bool irq_remapped(struct irq_cfg *cfg) > { > @@ -93,6 +96,12 @@ static inline void irq_remap_modify_chip_defaults(struct irq_chip *chip)
> --- a/drivers/iommu/irq_remapping.c > +++ b/drivers/iommu/irq_remapping.c > @@ -302,3 +302,14 @@ void irq_remap_modify_chip_defaults(struct irq_chip *chip) > chip->irq_eoi = ir_ack_apic_level; > chip->irq_set_affinity = x86_io_apic_ops.set_affinity; > } > + > +bool setup_remapped_irq(int irq, struct irq_cfg *cfg, struct irq_chip *chip) > +{ > + if (irq_remapped(cfg)) { > + irq_set_status_flags(irq, IRQ_MOVE_PCNTXT); > + irq_remap_modify_chip_defaults(chip); > + return true; > + } else { > + return false; > + } > +}
What about
bool setup_remapped_irq(int irq, struct irq_cfg *cfg, struct irq_chip *chip) { if (!irq_remapped(cfg)) return false; irq_set_status_flags(irq, IRQ_MOVE_PCNTXT); irq_remap_modify_chip_defaults(chip); return true; }
Sebastian
| |