| Date | Sun, 26 Aug 2012 20:03:23 +0200 | From | Sebastian Andrzej Siewior <> | Subject | Re: [PATCH 04/19] x86, io_apic: Introduce x86_io_apic_ops.print_entries for debugging |
| |
On Mon, Aug 20, 2012 at 03:55:50PM +0200, Joerg Roedel wrote: > This call-back is used to dump IO-APIC entries for debugging > purposes into the kernel log. VT-d needs a special routine > for this and will overwrite the default.
Okay, again: code basically does what it did, it has been shifted around and is now called directly.
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com> > diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c > index e0b18f3..321db1a 100644 > --- a/drivers/iommu/intel_irq_remapping.c > +++ b/drivers/iommu/intel_irq_remapping.c > @@ -617,6 +617,10 @@ static int __init intel_enable_irq_remapping(void) > goto error; > > irq_remapping_enabled = 1; > + > + /* VT-d needs a special routine to print IO-APIC entries */ Seriously? That that's why you overwrite it with a different function :)
> + x86_io_apic_ops.print_entries = intel_ir_io_apic_print_entries; > + > pr_info("Enabled IRQ remapping in %s mode\n", eim ? "x2apic" : "xapic"); > > return eim ? IRQ_REMAP_X2APIC_MODE : IRQ_REMAP_XAPIC_MODE;
Sebastian
|