Messages in this thread | | | Date | Fri, 24 Aug 2012 13:07:38 +0530 | From | Ananth N Mavinakayanahalli <> | Subject | Re: [PATCH v4 2/2] powerpc: Uprobes port to powerpc |
| |
On Fri, Aug 24, 2012 at 05:07:31PM +1000, Benjamin Herrenschmidt wrote: > On Fri, 2012-08-24 at 11:13 +1000, Michael Ellerman wrote: > > > > Yeah. A NULL regs here is a kernel bug, so I think it's actually > > preferable to crash than silently return. > > Or best, if you think there's a remote chance that the bug might hit: > > if (WARN(!regs)) > return
Incorporated this and other suggestions from Michael in v5 I just posted.
Ananth
| |