lkml.org 
[lkml]   [2012]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH V5 0/5] clk: mmp: add clock framework for mmp
Date
Quoting Chao Xie (2012-08-19 19:55:10)
> From: Chao Xie <chao.xie@marvell.com>
> arch/arm/mach-mmp/Kconfig | 3 +
> drivers/clk/Makefile | 3 +
> drivers/clk/mmp/Makefile | 9 +
> drivers/clk/mmp/clk-apbc.c | 152 ++++++++++++++
> drivers/clk/mmp/clk-apmu.c | 97 +++++++++
> drivers/clk/mmp/clk-frac.c | 153 ++++++++++++++
> drivers/clk/mmp/clk-mmp2.c | 449 ++++++++++++++++++++++++++++++++++++++++++
> drivers/clk/mmp/clk-pxa168.c | 346 ++++++++++++++++++++++++++++++++
> drivers/clk/mmp/clk-pxa910.c | 320 ++++++++++++++++++++++++++++++
> drivers/clk/mmp/clk.h | 35 ++++

Looks like you are not removing your arch/arm/mach-mmp/clock.c. Is that
intentional?

When I apply your series against v3.6-rc3 I find that compilation breaks
with mmp2_defconfig due to conflicting definitions for the clk api
(clk_enable, clk_set_rate, etc). This is not surprising since your
legacy clock code is neither deleted nor removed from compilation
conditionally by checking for CONFIG_COMMON_CLK.

Did I somehow manage to misapply your patches or should your patches
have removed the arch-specific clock framework as well?

Regards,
Mike

> 10 files changed, 1567 insertions(+), 0 deletions(-)
> create mode 100644 drivers/clk/mmp/Makefile
> create mode 100644 drivers/clk/mmp/clk-apbc.c
> create mode 100644 drivers/clk/mmp/clk-apmu.c
> create mode 100644 drivers/clk/mmp/clk-frac.c
> create mode 100644 drivers/clk/mmp/clk-mmp2.c
> create mode 100644 drivers/clk/mmp/clk-pxa168.c
> create mode 100644 drivers/clk/mmp/clk-pxa910.c
> create mode 100644 drivers/clk/mmp/clk.h


\
 
 \ /
  Last update: 2012-08-25 03:01    [W:0.115 / U:2.724 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site