Messages in this thread | | | Date | Fri, 24 Aug 2012 14:11:08 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 01/14] aoe: for performance support larger packet payloads |
| |
On Fri, 17 Aug 2012 21:18:37 -0400 Ed Cashin <ecashin@coraid.com> wrote:
> --- a/drivers/block/aoe/aoeblk.c > +++ b/drivers/block/aoe/aoeblk.c > @@ -279,6 +279,9 @@ aoeblk_gdalloc(void *vp) > if (bdi_init(&d->blkq->backing_dev_info)) > goto err_blkq; > spin_lock_irqsave(&d->lock, flags); > + blk_queue_max_hw_sectors(d->blkq, BLK_DEF_MAX_SECTORS); > + d->blkq->backing_dev_info.ra_pages = BLK_DEF_MAX_SECTORS * 1024; > + d->blkq->backing_dev_info.ra_pages /= PAGE_CACHE_SIZE;
This seems a bit abusive of BLK_DEF_MAX_SECTORS, which is in units of 512-byte sectors. (BLK_DEF_MAX_SECTORS * 512)/PAGE_CACHE_SIZE would make sense.
| |